search

GeoFS-Extensions / autoland

Accessible plugins for GeoFS, an online flight simulator.
https://geofsautoland.wixsite.com/autoland
GNU General Public License v3.0
6 stars 2 forks source link

IDEA: Move the scripts to regular modules that compile to requirejs #84

Closed Guy-Adler closed 2 years ago

Guy-Adler commented 3 years ago

tsconfig.json's module option allows us to compile normal modules (using regular import/export syntax) into AMD modules that can be used with requirejs. I think the move will modernize and simplify our codebase. @GeoFS-Extensions/authors what are your opinions?

nicolas377 commented 3 years ago

This seems like a great idea to me! We could play around with that in a branch of one of the scripts for now, and maybe integrate that into either a 3.2 or 3.3 patch!

nicolas377 commented 3 years ago

This is something made a lot easier by integrating to a monorepo (#81). Hopefully, the monorepo will be on main by next Monday for us to use.

nicolas377 commented 3 years ago

@Guy-Adler could you draft this one up for fmc?

Guy-Adler commented 3 years ago

I have been working on it for the past few days, just didn't push the branch yet. Converting FMC is trickier because it redefines some of the exports, which is not possible on es2020.

Guy-Adler commented 3 years ago

@nicolas377 I finished all the scripts. All the repos now have a branch called es2020-imports containing the new modules, ready to be merged to the main branch or moved to the monorepo (#81).

nicolas377 commented 3 years ago

I'm still working on the monorepo's infrastructure, so I'll move that in.