GeoJSON-Net / GeoJSON.Net.Contrib

Repository for all GeoJSON.Net *.Contrib projects
MIT License
36 stars 22 forks source link

Nuget package for GeoJSON.Net.Contrib.Wkb with Target Framework 4.5 #17

Closed tentakles closed 6 years ago

tentakles commented 6 years ago

Is it possible to create a Nuget-package for GeoJSON.Net.Contrib.Wkb targeting .NET Framework 4.5 as well?

The current one requires .NET Framework 4.5.2 afaik.

Afaik, GeoJSON.Net and dependencies has packages targeting .NET Framework 4.5 as well.

thanks

xfischer commented 6 years ago

GC Wdis, which stands for "Good catch, Will do it soon" ;)

xfischer commented 6 years ago

Packages 0.1.2 targeting Net 45 released. Can you check if everything is OK ? Thanks for the report @tentakles.

tentakles commented 6 years ago

Does not work for me im afraid;

Even though the dlls now reside in a "net45"-folder etc, Jetbrains Dotpeek tells me that the packaged file in 0.1.2 still targets .Net framework v.4.5.2

See picture:

geojsondotnetcontrib

Also, when i try to compile my v4.5 app i get this error:

1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin\Microsoft.Common.CurrentVersion.targets(1964,5): warning MSB3274: The primary reference "GeoJSON.Net.Contrib.Wkb, Version=1.0.0.0, Culture=neutral, processorArchitecture=MSIL" could not be resolved because it was built against the ".NETFramework,Version=v4.5.2" framework. This is a higher version than the currently targeted framework ".NETFramework,Version=v4.5".

I also tried with an empty console app targeting v4.5 with just the geojson.net and contrib.wkb (v 0.1.2) and got the same error.

xfischer commented 6 years ago

Ok I’ll Check that tonight. Thanks for testing.

xfischer commented 6 years ago

I've checked again and released nugets 0.1.3. Can you test again ? Thanks

tentakles commented 6 years ago

Seems to work great for me now :)

Thank you very much for fix and quick resolve.