search

GeoJSON-Net / GeoJSON.Net.Contrib

Repository for all GeoJSON.Net *.Contrib projects
MIT License
36 stars 22 forks source link

Support for NETStandard #20

Closed xplicit closed 4 years ago

xplicit commented 5 years ago

Current version of library does not support NETStandard. Is it possible to make it compatible with NETStandard 2.0?

xfischer commented 5 years ago

Hi @xplicit. Which library are you focused at ? (There are 3 here)

xplicit commented 5 years ago

I'm trying to convert WKT to GeoJson and looks like GeoJSON.Net.Contrib.MsSqlSpatial should do this stuff. But it is targeted to .NET 4.5 only without supporting NETStandard in csproj file.

alvaromongon commented 5 years ago

Hi @xplicit, feel free to try to target netstandad and launch a PR, but I am not sure if all the necessary libraries will be available in standard.

In the worst case scenario you could target a newer version of de full framework, like 4.6.1 that is compatible with standard 2.0

ghost commented 4 years ago

I created https://github.com/GeoJSON-Net/GeoJSON.Net.Contrib/pull/28. This does not impact MsSqlSpatial. Is it desired for me to do anything with it, such as the above target of framework 4.6.1?

xfischer commented 4 years ago

If it targets net45; it is compatible with netstandard20. I don't get why you need explicit netstandard20 targeting ?

ghost commented 4 years ago

Pulling in the package as it is into a .netcore 3.1 project causes warnings to be issued; I don't believe this is results in any errors. Placing the library onto .netstandard should eliminate these warnings.

xfischer commented 4 years ago

@trevor-thoele ah yes you are right. This is causing suspicion of runtime errors.