search

GeoJSON-Net / GeoJSON.Net.Contrib

Repository for all GeoJSON.Net *.Contrib projects
MIT License
36 stars 22 forks source link

Add SQL server types reference #23

Closed neorth closed 4 years ago

neorth commented 4 years ago

Fixes EntityFramework tests.

xfischer commented 4 years ago

Not sure about this. This will oblige callers to migrate to SqlTypes 14, I think this would cause runtime errors when playing around with older types (ie SQL 2008 R2)

neorth commented 4 years ago

You're probably right in that. Do you have any other walk-around to make tests running in newer environments?

xfischer commented 4 years ago

What's the exact problem ? The tests don't run in your environment ? I'll try to launch them later on today.

SQL Types have been a headache since the beginning. A good workaround was to use Serialize/Deserialze from binary as long as I remember. More on that later.

neorth commented 4 years ago

Just tested on a freshly installed computer but gets the same result: image There might be other solutions to this than mine but I feel it should at least work out of the box without having to install something systemwide.

xfischer commented 4 years ago

Hi @Neorth What would you need EF for ? I think the next step if you're into EF should be to install SQL Server isn't it ? Aaannnd this may fix the problem. Let me know.

@alvaromongon, hi! Any ideas on that, as you were the main contributor for this side of GeoJSON.Net

neorth commented 4 years ago

Not necessarily, I'm using an Azure SQL DB that keeps track of user posted geometries as DbGeometries.

xfischer commented 4 years ago

OK @Neorth. Let's give @alvaromongon two days. Passed this delay, I'll merge your PR.

Thanks!

milang commented 4 years ago

@xfischer please note that this PR has been obsoleted by #31 (which is now merged into master). I recommend closing this pull request.

@Neorth could you please try re-running the tests using the latest master? As long as you have .NET Core SDK 3.0+ (which you should have if you installed Visual Studio 2019), the tests should now "just work" both on the command line (see README.md) and in your IDE.

xfischer commented 4 years ago

Closing this PR, please feel free to add any comments here.