xfischer
commented
4 years ago I don't think we should obsolete the single argument constructor. It's still valid to call the FromBinary method without the crs-argument so I think we should handle it the same way. Or maybe I'm missing the idea behind making it obsolete?
- Your new signature is great with the optional argument, I was just pointing out that adding an argument is a breaking change, and we should let the old signature "alive" but mark it as obsolete. The new one you did is perfectly fine. If someone references a library A and A references GeoJson, then pushing this would break A, even if it's an additional parameter.
- It's cleaner to keep one signature, so no need to have both
And lastly, thank you for submitting those PRs :)
neorth
I don't think we should obsolete the single argument constructor. It's still valid to call the FromBinary method without the crs-argument so I think we should handle it the same way. Or maybe I'm missing the idea behind making it obsolete?