GeoJSON-Net / GeoJSON.Net

.Net library for GeoJSON types & corresponding Json.Net (de)serializers
MIT License
446 stars 167 forks source link

Move serializers to a separate project and NuGet to support System.Text.Json in another project and NuGet #148

Open xperiandri opened 4 years ago

xperiandri commented 4 years ago

Create a new project for NewtonSoft.JSON serializers and issue them as a separate NuGet package

matt-lethargic commented 4 years ago

@xfischer I've been looking at the issues that System.Text.Json has brought about and thinking that this could be a solution in a v2 of GeoJSON.Net.

Thoughts?

xfischer commented 4 years ago

Yes I agree to set System.Text.Json as the default (de)serializer, and provide backwards compatibility as a separate NuGet package, as suggested by @xperiandri. Let's create a branch for that purpose and get started. @matt-lethargic did you look how to migrate existing converters ? As I saw quickly it seems like a lot of work to support System.Text.Json, but hopefully we are covered with unit tests.

I'll take care of the Contribs in a similar new-branch approach.

Related MS docs :

matt-lethargic commented 4 years ago

I haven't looked at the migration properly yet, but have docs in front of me. Will start a v2 branch

steveoh commented 4 years ago

I've been migrating a similar project to STJ and it's not that bad. I was going to fork this for my project but I am glad that it is on your radar and I am happy to contribute. How's the progress so far?

steveoh commented 4 years ago

Since there wasn't any visible progress, I went ahead and forked. Please provide some early feedback and participate!