search

GeoJSON-Net / GeoJSON.Text

.Net library for GeoJSON types & corresponding System.TExt.Json (de)serializers
MIT License
39 stars 10 forks source link

GitHub action to release to nuget #4

Closed matt-lethargic closed 2 years ago

matt-lethargic commented 2 years ago

With this change I've added in a deploy job to the ci build action that will trigger when a GitHub Release is created with the name format v1.2.3 and subsequently push the package to Nuget

I've also created a new key.snk that the project uses when signing itself at build time.

codecov-commenter commented 2 years ago

Codecov Report

Merging #4 (1789750) into main (d0bd715) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   58.96%   58.96%           
=======================================
  Files          31       31           
  Lines         753      753           
  Branches      192      192           
=======================================
  Hits          444      444           
  Misses        222      222           
  Partials       87       87
Flag Coverage Δ
unittests 58.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0bd715...1789750. Read the comment docs.

MartinCarpentier commented 2 years ago

Looks really nice, and great that it works with the github releases.

Could it make sense to split the build/test responsibility away from the deployment responsibility, and create 2 workflow files?

Something like

Furthermore, does it also allow creating packages with formats like below? v1.2.3-preview1

Since it would be great to be able to do preview releases.