search

GeoLatte / geolatte-geom

A geometry model that conforms to the OGC Simple Features for SQL specification.
Other
132 stars 63 forks source link

Fix for parsing of GEOMETRYCOLLECTION with MULTIPOINT (Oracle). #141

Closed Kermit closed 2 years ago

Kermit commented 2 years ago

PR for issue #140

According to https://docs.oracle.com/database/121/SPATL/sdo_geometry-object-type.htm#GUID-270AE39D-7B83-46D0-9DD6-E5D99C045021__BGHDGCCE, SDO_INTERPRETATION with MULTIPOINT (cluster) describe how many points we'll have in MULTI geometry.

To get it work properly I had to set POINT_CLUSTER as compound geometry and add internal variable in CompoundIElemInfoTriplet.

To be honest, I'm not sure that changes in CompoundIElemInfoTriplet:numParts() and CompoundIElemInfoTriplet:getInterpretation() are ok, even though all test are passing.

Last change is adding small and simple test for such geometries.

Let me know if I should do anything more with it.

maesenka commented 2 years ago

I've investigated this a bit more. The current SDO_GEOMETRY codec simply doesn't support Point clusters.

Technically, they are not compound. ("SDO_ETYPE values 4, 1005, 2005, 1006, and 2006 are considered compound elements."). So your solution isn't entirely correct imho.

I'm going to add support for point clusters, and will certainly take elements from your code.

mstankala commented 2 years ago

Hi, Is this Project still alive ? Last Version was released in July 2021 The website http://www.geolatte.org is not working/exists anymore?

Best regards, Marek

maesenka commented 2 years ago

It definitely is alive.

Updates have become less frequent but development is ongoing. And working on your PR (and related bugs) is still ongoing.

The old geolatte.org website doesn't exist anymore. Do we still reference that somewhere?

Regards,

Karel Maesen

On Thu, Jan 27, 2022 at 4:16 PM Marek @.***> wrote:

Hi, Is this Project still alive ? Last Version was released in July 2021 The website http://www.geolatte.org is not working/exists anymore?

Best regards, Marek

— Reply to this email directly, view it on GitHub https://github.com/GeoLatte/geolatte-geom/pull/141#issuecomment-1023319205, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADSH6NK5DWFMCKJ2B4FMVLUYFOVZANCNFSM5JACPIEQ . You are receiving this because you commented.Message ID: @.***>

maesenka commented 2 years ago

Fixed in commit 6efbfd8