search

GeoLatte / geolatte-geom

A geometry model that conforms to the OGC Simple Features for SQL specification.
Other
134 stars 63 forks source link

Invalid arcs #59

Closed GisMarsch closed 6 years ago

GisMarsch commented 6 years ago

This Pull Request contains three changes I have made for GEOGRAT.

  1. Some of our customers had a NPE because they got an SDO_POINT in ORACLE with Z part being "null". This was because of Autoboxing and conversion of null Double to double.
  2. Improvement needed by GEOGRAT to return if a polygon / geometry was stored as ORACLE BoundingBox
  3. This may be the most interesseting for community: I found a bug concerning linearization of linestrings. In some cases linearization used to wrong direction and linearized counter-clockwise, but clockwise was required. I demonstrated this by org.geolatte.geom.cga.CircularArcLinearizerTest.testArcClockwise(): Without the fix this test will fail, because linearization of arc is done counter-clockwise.

Feel free the include into master if you like too.

Sorry that this may contain my changes in pom.xml too. Did those changes becuase I had some problems concerning collections api and because of own versioning.

maesenka commented 6 years ago

Thank you for this contribution!

I accepted the changes, with the exception of item 2 because this really is very GEOGRAT specific, and may introduce unexpected behavior for other users.