feat: add github workflow

[BobyMCbobs]

to replace travis jobs

Proposed Changes

Resolves #.

Changes proposed in this pull request:

• use GitHub Actions

Production Changes

The following production changes are required to deploy these changes:

• None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer. When assigning the code review please consider the expertise needed to review the changes.

• [ ] This is a content (documentation, web page etc) only change.
• [x] This is a minor change (meta data, bug fix, improve test coverage etc).
• [ ] This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

[BobyMCbobs]

Having a hard time getting this to build. Dapper should be separated out. Keeping on failing on go install ... https://github.com/GeoNet/fits/actions/runs/5686508902/job/15413410146?pr=218#step:18:208

Why is there's a separate dockerbuild.sh in ./dapper? https://github.com/GeoNet/fits/blob/main/dapper/dockerbuild.sh

it appears to not be consumed in the travis job

[CallumNZ]

@junghao I've always wondered why dapper sits in fits like this (if it fits it sits?). @BobyMCbobs are you suggesting it should sit inside cmd with fits-api ?

That dockerbuild.sh is vestigial, can be deleted.

[junghao]

@CallumNZ @BobyMCbobs https://github.com/GeoNet/fits/blob/main/build.sh#L27 The build script only use /cmd/fits-api, all the rest commands using /dapper/cmd/....

Why dapper under fits? Check the readme https://github.com/GeoNet/fits/tree/main/dapper. The purpose of dapper is to replace fits (see how long we've been hating fits). Unfortunately it never happened.

BTW, this is a public repo. So don't ask too much :D

[BobyMCbobs]

@junghao I've always wondered why dapper sits in fits like this (if it fits it sits?).

:laughing:

@BobyMCbobs are you suggesting it should sit inside cmd with fits-api ?

yeah, that'd be a good idea

That dockerbuild.sh is vestigial, can be deleted.

Sounds like a plan

[BobyMCbobs]

@CallumNZ @BobyMCbobs https://github.com/GeoNet/fits/blob/main/build.sh#L27 The build script only use /cmd/fits-api, all the rest commands using /dapper/cmd/....

:+1:

Why dapper under fits? Check the readme https://github.com/GeoNet/fits/tree/main/dapper. The purpose of dapper is to replace fits (see how long we've been hating fits). Unfortunately it never happened.

I might recommend a new repo for dapper, if possible.

BTW, this is a public repo. So don't ask too much :D

[BobyMCbobs]

I'm really unsure why one dapper build job passes while another fails.

• fail: https://github.com/GeoNet/fits/actions/runs/5686696948/job/15413939446?pr=218#step:18:192
• pass: https://github.com/GeoNet/fits/actions/runs/5686696948/job/15413939303?pr=218#step:18:188

[BobyMCbobs]

The structure including Dapper is too complicated for this flow to do a go build smoke test just for dapper and exclude dapper-send-test. I'm going to remove it for now. Dapper should be in a different repo in the future where there's an appropriate go.mod in the root of the repo

cc @junghao

[BobyMCbobs]

@junghao @sue-h-gns, thank you!