GeoNode / ansible-geonode

Ansible GeoNode Scripts
https://galaxy.ansible.com/GeoNode/geonode/
7 stars 21 forks source link

Updated GeoNode ansible role to work with current GeoNode master #48

Closed kalxas closed 5 years ago

t-book commented 5 years ago

@kalxas You’re starting the celery service https://github.com/GeoNode/ansible-geonode/blob/master/tasks/celery.yml#L13 But I cannot see that ASYNC_SIGNALS is set to true. (So Signals might still run synchronous?)

ASYNC_SIGNALS = ast.literal_eval(os.environ.get('ASYNC_SIGNALS', 'false')) (False by default) https://github.com/GeoNode/geonode/blob/master/geonode/settings.py#L1331

If it’s not somewhere set maybe it could be added to geonode-project settings file or as ENV var?

kalxas commented 5 years ago

@t-book I have not done any changes to the celery task

t-book commented 5 years ago

@kalaxas With current settings it's enabled but not used. (IMHO this is not relevant for this PR. We can change it in a next step) Anyways, I could not save maps , I think the local_settings needs to be updated relating geoserver location. Have you tested creating a new map?

kalxas commented 5 years ago

Thanks for the feedback @t-book I am working on it. Shall we merge this one and open a new PR?

kalxas commented 5 years ago

Thanks @t-book for the review. @afabiani @francbartoli @ingenieroariel @simod can you please review/merge?

ingenieroariel commented 5 years ago

I have been working on a VM created with this ansible role these past few weeks and all looks good to me. Merging.

kalxas commented 5 years ago

Thanks @ingenieroariel