search

GeoNode / geonode

GeoNode is an open source platform that facilitates the creation, sharing, and collaborative use of geospatial data.
https://geonode.org/
Other
1.41k stars 1.11k forks source link

Rename service nginx #12249

Closed t-book closed 1 month ago

t-book commented 1 month ago

One is not forced to use NGINX as proxy server, hence the service name geonode is misleading

https://github.com/GeoNode/geonode/blob/684a1f3572a39b6ab8ba5a6ce7ea4d96fc739c8c/docker-compose.yml#L66-L70

Would it not be clearer that the current django service is namend geonode and nginx something like geonode-proxy?

ridoo commented 1 month ago

Once I was confused about this, too. However, I got used to it now and do not have a strong opinion on renaming both anymore.

giohappy commented 1 month ago

Same as @ridoo. I have also thought about this renaming several times, but then I soon thought to all the renaming that it would imply in terms of docs, etc. and I didn't consider it was worth it! :)

t-book commented 1 month ago

You are right @giohappy this would bring some work that for now is definitely not worth it. Maybe somewhere in future. Closing here.