search

GeoNode / geonode

GeoNode is an open source platform that facilitates the creation, sharing, and collaborative use of geospatial data.
https://geonode.org/
Other
1.41k stars 1.11k forks source link

[Fixes #12124] GNIP 100: Assets #12338

Open mattiagiupponi opened 2 weeks ago

mattiagiupponi commented 2 weeks ago
## Checklist > Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them. For all pull requests: - [x] Confirm you have read the [contribution guidelines](https://github.com/GeoNode/geonode/blob/master/CONTRIBUTING.md) - [x] You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation) - [x] Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones. The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules): - [x] There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users) - [x] The issue connected to the PR must have Labels and Milestone assigned - [x] PR for bug fixes and small new features are presented as a single commit - [x] Commit message must be in the form "[Fixes #] Title of the Issue" - [ ] New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented - [ ] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR) - [ ] This PR passes the QA checks: black geonode && flake8 geonode - [ ] Commits changing the **settings**, **UI**, **existing user workflows**, or adding **new functionality**, need to include documentation updates - [ ] Commits adding **new texts** do use gettext and have updated .po / .mo files (without location infos) **Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.**
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 68.11460% with 345 lines in your changes missing coverage. Please review.

Project coverage is 64.18%. Comparing base (eb9bfe0) to head (2cf7d6c).

:exclamation: Current head 2cf7d6c differs from pull request most recent head 74d64c2

Please upload reports for the commit 74d64c2 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12338 +/- ## ========================================== + Coverage 64.14% 64.18% +0.03% ========================================== Files 872 886 +14 Lines 52328 53275 +947 Branches 6478 6584 +106 ========================================== + Hits 33564 34192 +628 - Misses 17275 17569 +294 - Partials 1489 1514 +25 ```
etj commented 5 days ago

The PR should be REBASED AND MERGED