search

GeoNode / geonode

GeoNode is an open source platform that facilitates the creation, sharing, and collaborative use of geospatial data.
https://geonode.org/
Other
1.41k stars 1.11k forks source link

[Fixes #12341] Asset download handler and link generator #12343

Closed mattiagiupponi closed 1 week ago

mattiagiupponi commented 1 week ago
## Checklist > Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them. For all pull requests: - [ ] Confirm you have read the [contribution guidelines](https://github.com/GeoNode/geonode/blob/master/CONTRIBUTING.md) - [ ] You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation) - [ ] Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones. The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules): - [ ] There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users) - [ ] The issue connected to the PR must have Labels and Milestone assigned - [ ] PR for bug fixes and small new features are presented as a single commit - [ ] Commit message must be in the form "[Fixes #] Title of the Issue" - [ ] New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented - [ ] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR) - [ ] This PR passes the QA checks: black geonode && flake8 geonode - [ ] Commits changing the **settings**, **UI**, **existing user workflows**, or adding **new functionality**, need to include documentation updates - [ ] Commits adding **new texts** do use gettext and have updated .po / .mo files (without location infos) **Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.**
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 80.55556% with 7 lines in your changes missing coverage. Please review.

Project coverage is 64.35%. Comparing base (d008bad) to head (cd8bb3f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## assets_master #12343 +/- ## ================================================= + Coverage 64.34% 64.35% +0.01% ================================================= Files 885 885 Lines 53052 53076 +24 Branches 6544 6548 +4 ================================================= + Hits 34134 34155 +21 - Misses 17406 17408 +2 - Partials 1512 1513 +1 ```