GeoNode / geonode

GeoNode is an open source platform that facilitates the creation, sharing, and collaborative use of geospatial data.
https://geonode.org/
Other
1.44k stars 1.13k forks source link

[Fixes #12382] Fix permsission on API for assets #12383

Closed mattiagiupponi closed 3 months ago

mattiagiupponi commented 3 months ago

The permission logic is already inside the asset API, no need to add additional classes. The UserHasPerms was trying to find the PK of the asset as ResourceBase, so it should be removed

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.17%. Comparing base (773a6e1) to head (66adc7e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12383 +/- ## ========================================== - Coverage 64.17% 64.17% -0.01% ========================================== Files 886 886 Lines 53279 53278 -1 Branches 6584 6584 ========================================== - Hits 34194 34191 -3 - Misses 17571 17574 +3 + Partials 1514 1513 -1 ```