search

GeoNode / geonode

GeoNode is an open source platform that facilitates the creation, sharing, and collaborative use of geospatial data.
https://geonode.org/
Other
1.43k stars 1.12k forks source link

Filter get_defined_contact_role is not defined #12533

Open etj opened 2 weeks ago

etj commented 2 weeks ago

The filter is only referenced once in the full_metadata.xml file:

https://github.com/GeoNode/geonode/blob/ec24c991c50fc9c0078d3994d35f133608376fbd/geonode/catalogue/templates/catalogue/full_metadata.xml#L16

The contact roles are not added in the XML metadata document indeed.

Only checked on master, probably it's also on other branches.

gannebamm commented 2 weeks ago

@ahmdthr maybe this is related to our issue with GDI-DE compatability and missing entries in the XML (https://github.com/Thuenen-GeoNode-Development/Sprints/issues/6 & https://github.com/Thuenen-GeoNode-Development/thuenen_atlas/issues/34)?

ahmdthr commented 2 weeks ago

@gannebamm Let me take a look in detail.

@etj It most probably is referring to:

https://github.com/GeoNode/geonode/blob/ec24c991c50fc9c0078d3994d35f133608376fbd/geonode/base/models.py#L1767

but I will take a look at it soon, and report back.

ahmdthr commented 1 week ago

@gannebamm Our GDI-DE compliance issue was not really related to this, but our generated metadata didn't include multiple contacts. But it is now fixed, we now get a GDI-DE compliant metadata with multiple contacts.

@etj As I suspected, incorrect property was being referred. I have created a PR to fix that.