Closed ridoo closed 1 month ago
@ridoo the test suite is failing but it doesn't seem related to your PR. Do you have time to check what's wrong?
@giohappy thanks for your review!
AFAICS the PR is on top of 'master' which seem to fail similarly:
I was on sick leave yesterday and, unfortunately, will not have time to dig deeper into it next week (which is a short one for me due to upcoming vacation 🥳). I removed the draft status anyway.
Hey @ridoo if you merge master in your branch, the test failing unrelated tests should pass 😄
@mattiagiupponi thanks, should be ready to merge now
EDIT: Any chance to get it backported to v4.3.x
?`:)
Any chance to get it backported to v4.3.x?`:)
@ridoo technically 4.3.x is not supported anymore now that we have 4.4.x. Can't you upgrade?
Will have to check. Project context, you know?! As there are some major changes I did not dig into yet, I am a bit hesitant. But could also be a chance to catch-up. You can do the merge without waiting on me.
This is a quick proposal to ensure a user gets all permissions assigned, including custom permissions which are unknown to GeoNode but potentially created and needed by contrib apps.
See #12639 and https://github.com/GeoNode/geonode/discussions/12635 for more details
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.