GeoNode / geonode

GeoNode is an open source platform that facilitates the creation, sharing, and collaborative use of geospatial data.
https://geonode.org/
Other
1.46k stars 1.13k forks source link

[Fixes #12639] Adds all assigned group permissions to user #12640

Closed ridoo closed 1 month ago

ridoo commented 1 month ago

This is a quick proposal to ensure a user gets all permissions assigned, including custom permissions which are unknown to GeoNode but potentially created and needed by contrib apps.

See #12639 and https://github.com/GeoNode/geonode/discussions/12635 for more details

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

giohappy commented 1 month ago

@ridoo the test suite is failing but it doesn't seem related to your PR. Do you have time to check what's wrong?

ridoo commented 1 month ago

@giohappy thanks for your review!

AFAICS the PR is on top of 'master' which seem to fail similarly:

https://app.circleci.com/pipelines/github/GeoNode/geonode/17373/workflows/b41015bd-12e7-4918-a767-01a918c53853

I was on sick leave yesterday and, unfortunately, will not have time to dig deeper into it next week (which is a short one for me due to upcoming vacation 🥳). I removed the draft status anyway.

mattiagiupponi commented 1 month ago

Hey @ridoo if you merge master in your branch, the test failing unrelated tests should pass 😄

ridoo commented 1 month ago

@mattiagiupponi thanks, should be ready to merge now

EDIT: Any chance to get it backported to v4.3.x?`:)

giohappy commented 1 month ago

Any chance to get it backported to v4.3.x?`:)

@ridoo technically 4.3.x is not supported anymore now that we have 4.4.x. Can't you upgrade?

ridoo commented 1 month ago

Will have to check. Project context, you know?! As there are some major changes I did not dig into yet, I am a bit hesitant. But could also be a chance to catch-up. You can do the merge without waiting on me.