GeoNode / geoserver-geonode-ext

GeoNode's GeoServer Extensions
12 stars 42 forks source link

Prepare GS 2.23-SNAPSHOT to test GeoFence WPS rules #146

Closed etj closed 1 year ago

etj commented 1 year ago

We need a 2.22 version with this PR included -- so we need to build from this branch.

Once the PR is stable, we'll be proposing the backport out from the WIP status.

We may want to build GeoServer directly, without using the POMs from this very project. There's a initial investigation about the needed modules in this document

etj commented 1 year ago

Please note that the GS built this way will still have the hibernate-spatial-h2 to be replaced.

etj commented 1 year ago

We may want to try out GeoServer 2.23 (master, at the moment), so that the backport of the GeoFence improvements is not needed.

In this case we will make a release of GeoNode 4.1.something just after GS 2.23.0 comes out.

giohappy commented 1 year ago

@afabiani @etj as agreed the following will be done:

Regarding the replacement of jars performed inside the Dockerfile (second point above), what about moving this step inside the Jenkins Job? Is there any valid reason for doing it at that stage?

afabiani commented 1 year ago

@giohappy we do this inside the Dockerfile because we are sure we can connect and confgiure GeoFence to a postgis DB. In the common use case GeoFence must be configured to store the rules on a local H2 store

giohappy commented 1 year ago

@giohappy we do this inside the Dockerfile because we are sure we can connect and confgiure GeoFence to a postgis DB. In the common use case GeoFence must be configured to store the rules on a local H2 store

Ok but we're building Geoserver for GeoNode, where we assume that we are using PostGIS. I don't see any context where this wouldn't be the case.

EDIT: I get your pont @afabiani. You mean that those jars need the .properties file generated from the template file only for the dockerized setup.

etj commented 1 year ago

@giohappy it would be nice having it built by maven and deployed somewhere, so that it can also be used outside a dockerized environment (e.g. for developing)

afabiani commented 1 year ago

As agreed with @etj we will modify the current GeoSolutions Jenkins build script in order to:

  1. Build an updated https://artifacts.geonode.org/2.23.0/geonode-geoserver-ext-web-app-data.zip out of a dedicated repository
  2. Build an updated https://artifacts.geonode.org/2.23.0/geoserver_vanilla.war out of a maven build including the official plugins
  3. Build an updated https://artifacts.geonode.org/2.23.0/geoserver.war wich adds the following to the geoserver_vanilla.war a. The GeoNode base GEOSERVER_DATA_DIR b. The updated mapfish-print JARs from the GeoSolutions mapfish print-lib

NOTE: check if any other JAR is needed from the external repos.

afabiani commented 1 year ago

@giohappy @etj 2.23.x artifacts ready:

giohappy commented 1 year ago

nice @afabiani Once everything is confirmed to work we should:

afabiani commented 1 year ago

@giohappy @etj FWI I had to manually add the following missing JARs to GeoServer in order to make it working. Other than this everything is working smoothly with GeoNode 4.1.x

https://github.com/GeoNode/geoserver-geonode-ext/tree/main/libs

giohappy commented 1 year ago

For the moment I've only built the Docker image for data 2.23.x, since it was needed to upgrade master and development demo.

The official image for GS 2.23.x will be built and uploaded once the tag has been cat in Geoserver.