GeoNodeUserGroup-DE / contrib_externalapplications

GeoNode contrib module adding an externalapplication resource
GNU General Public License v3.0
0 stars 0 forks source link

Blank "view" URL in resource grid #8

Closed pchevali closed 1 day ago

pchevali commented 6 days ago

Hi,

I have been testing this contrib app but and I was not able to have the "View" link to follow the detail url. I only tested with the latest version of geonode (4.3). It seems to me that this part is not working unless by specifying a "subtype" for the external application (I used document and it works).

This seems related to the following lines in geonode mapstore client ( but it hasn't changed since a while ):

https://github.com/GeoNode/geonode-mapstore-client/blob/master/geonode_mapstore_client/client/js/components/ResourceCard/ResourceCard.jsx#L44-L49

Am I missing something here ?

Regards

ridoo commented 5 days ago

@pchevali yes .. the problem is, that ATM there is no way to customize UI behaviour at this level of detail via contrib module. This is missing from the documentation, I guess. It is just a one-liner:

https://github.com/Thuenen-GeoNode-Development/geonode-mapstore-client/blob/112b26b45ac8fe85a129625c160a7998a531f8cf/geonode_mapstore_client/client/js/components/DetailsPanel/DetailsPanel.jsx#L157

There is a discussion focussing on dev experience when customizing geonode-mapstore-client which is IMHO expandable.

EDIT: I saw your is pointing to the ResourceCard component which would have to be changed as well (I think, we missed that in the fork I linked above).

pchevali commented 5 days ago

Ok I understand. So this must be the point where we need to fork the client. Indeed there are other changes related to externalapplications : https://github.com/search?q=repo%3AThuenen-GeoNode-Development%2Fgeonode-mapstore-client%20externalapplication&type=code

ridoo commented 1 day ago

@pchevali I will close this issue here for now.