search

GeoSales-Evolution / self-deployable-docker

Docker repo capable of deploying itself... or something like that
MIT License
2 stars 2 forks source link

Enables the use of the Docker API to add a host on a Container instance. #50

Open uxjp opened 8 months ago

uxjp commented 8 months ago

depends on https://github.com/GeoSales-Evolution/self-deployable-docker/pull/51

solves #52

next #53

jeffque commented 8 months ago

It seems that there is some other stuff in this PR that shouldn't be here. Maybe some other dependencies?

jeffque commented 8 months ago

Can you please refer to an issue that this PR is solving or, otherwise, provides a description explaining the problem?

uxjp commented 8 months ago

I guess I just turned a blind eye to https://github.com/GeoSales-Evolution/self-deployable-docker/pull/45

You right, the 3 previous commits shouldn't be there. But the code from PR 45 is needed since I coudn't execute my app that depends on the Ouroborus gem.

jeffque commented 8 months ago

I guess I just turned a blind eye to #45

You right, the 3 previous commits shouldn't be there. But the code from PR 45 is needed since I coudn't execute my app that depends on the Ouroborus gem.

I guess than add in the description "depends on #45" should suffice , @uxjp