search

GeoSamples / sesar-rest-api

SESAR REST API Spring Boot Project
Apache License 2.0
2 stars 1 forks source link

Docker build configuration #26

Closed dhanrajteqfocus002 closed 2 years ago

SeanSCao commented 2 years ago

Build works for me. Could we change the docker service name from sesar to sesar-rest-api just for clarity sake? Also we should be able to remove the -DskipTests at this point right?

dhanrajteqfocus002 commented 2 years ago

Changing docker service name from sesar to sesar-rest-api in docker-compose is good idea, will change the service name. We need to keep -DskipTests as of now because we are using github action to build docker images and we don't know what IP the request will be coming to db while building process.