search

GeoStat-Framework / GSTools-Core

A Rust implementation of the core algorithms of GSTools.
GNU Lesser General Public License v3.0
10 stars 0 forks source link

Avoid count arrays in those variograms which do not actually return them #21

Closed adamreichold closed 2 years ago

adamreichold commented 2 years ago

@LSchueler I think this could be simplified further if variogram_unstructured and variogram_directional would not need to return their count arrays, but I do not know whether that is actually required by the Python code calling these functions.

LSchueler commented 2 years ago

Hi @adamreichold, nice hearing from you again! I'm not aware of any code actually using the counts. However, this is information which could be useful to quality check the estimates for the single bins (very small number of point pairs in a bin => oh oh) and which would be lost, if it is not returned. So, I think it would be a pretty high cost for simplifying the functions. Does this mean, that your PR is ready for a review?

adamreichold commented 2 years ago

Does this mean, that your PR is ready for a review?

Yes, I think so. It should be an improvement as it is (less initialization overhead, less task dispatch overhead) even if the API is unchanged.