GeoStat-Framework / GSTools

GSTools - A geostatistical toolbox: random fields, variogram estimation, covariance models, kriging and much more
https://geostat-framework.org
GNU Lesser General Public License v3.0
544 stars 71 forks source link

Use integer literals where appropriate #323

Closed eumiro closed 1 year ago

eumiro commented 1 year ago

Python 2 needed explicit float literals in order to do the correct math. In Python 3 this is not needed anymore. Using integers describes better the intention of the code.

This PR only changes floats that end with .0 to integers where appropriate.

LSchueler commented 1 year ago

Hi eumiro,

thank you for your PR. Sometimes it makes code easier to read if float literals are explicitly used. Therefore, I don't think that converting every integer valued float to an integer literal is the right solution for GSTools and I'll close this PR.

MuellerSeb commented 1 year ago

I agree with @LSchueler