search

GeoStat-Framework / GSTools

GSTools - A geostatistical toolbox: random fields, variogram estimation, covariance models, kriging and much more
https://geostat-framework.org
GNU Lesser General Public License v3.0
564 stars 74 forks source link

Cython: conditional compilation deprecated #343

Closed MuellerSeb closed 3 months ago

MuellerSeb commented 6 months ago

https://github.com/cython/cython/issues/4310

The conditional compilation introduced in #336 are deprecated by cython. I capped the cython version in #340 for now.

@LSchueler this should be cleaned up at some point.

MuellerSeb commented 6 months ago

Also cython_lint fails to read these files.

MuellerSeb commented 6 months ago

scikit learn has also solved this issue, but with an openmp helper module: https://github.com/scikit-learn/scikit-learn/blob/0c72e5448b9da3b0d9202aa5a2abbd9bff4c238a/sklearn/utils/_openmp_helpers.pyx#L25

MuellerSeb commented 3 months ago

Solved temporarily by #354