problem with geographical coordinates and GSTools Covmodel

GeoStat-Framework / PyKrige

Kriging Toolkit for Python

https://pykrige.readthedocs.io

BSD 3-Clause "New" or "Revised" License

740 stars 186 forks source link

problem with geographical coordinates and GSTools Covmodel #217

Closed Mercuron closed 1 year ago

Mercuron commented 2 years ago

Hi all!

1) I can't figure out how to beat the dim error. I set dim=2, but there is still error ValueError: GSTools: model dim is not 1 or 2. It's probably very silly, but I can't find where it is.

2) Why there is no predict method in the description of OK and UK methods? How then to predict results on new points?

values.csv

example_of_error.ipynb.zip

MuellerSeb commented 2 years ago

Hi there,

sorry for the late reply. This is a compatibility issue between GSTools and PyKrige. You were using the latlon mode of the Spherical model and PyKrige doesn't check for that correctly.

I need to investigate this.

MuellerSeb commented 2 years ago

This only affects OrdinaryKriging, since the support for geographic coordinates in UniversalKriging was not implemented.

TODOs:

fix pykrige_vario in GSTools, to return the yadrenko variogram if using latlon. https://github.com/GeoStat-Framework/GSTools/blob/5161e58419578beed74831e79d970a90f6975fa2/gstools/covmodel/base.py#L324
check for field_dim rather than dim when using latlon models from GSTools. This is the root of the error since the earth is 3D, the model dim is 3, but the field itself has only 2 dimensions.