search

GeoTIFF / geoblaze

Blazing Fast JavaScript Raster Processing Engine
http://geoblaze.io
MIT License
181 stars 28 forks source link

Directly specify which bundle to use in browser #170

Closed Tommatheussen closed 4 years ago

Tommatheussen commented 4 years ago

Type of PR

What is the Goal of the PR?

Fix issues with not being able to load the latest version in Angular and other projects

What is the Motivation for the PR?

We need this library in our application, version 0.2.2 works but we'd rather keep up to date with later versions. Trying to import the newest version throws errors similar to https://github.com/GeoTIFF/geoblaze/issues/165. As far as my understanding about webpack and bundling goes (please note, I haven't used those tools directly a lot, so my understanding might be limited), the browser key can be directly set to the script to use. Setting an object is usually used when other modules are required which are not available in the browser, which you can then shim or just completely ignore. (https://github.com/defunctzombie/package-browser-field-spec)

What Tests are Included?

None

DanielJDufour commented 4 years ago

awesome. I'll try to take a look at this later today! Thank you so much!

DanielJDufour commented 4 years ago

I just republished a new version with this pull request merged in. Please let me know if it doesn't work. Thank you again for bringing this to my attention.