search

GeoTIFF / georaster-layer-for-leaflet

Display GeoTIFFs and soon other types of raster on your Leaflet Map
https://geotiff.github.io/georaster-layer-for-leaflet-example/
Apache License 2.0
284 stars 57 forks source link

update: debugLevel defaults to 0 in production #58

Closed Rennzie closed 3 years ago

Rennzie commented 3 years ago

Closes https://github.com/GeoTIFF/georaster-layer-for-leaflet/issues/57

Rennzie commented 3 years ago

Hey @DanielJDufour I've made the changes you requested.

Let me know what the think re my reply to your review comment, particularly your thoughts on simplifying this and setting default to 0 and letting the user define when they want to see the logs.

DanielJDufour commented 3 years ago

Hi, @Rennzie . Sorry for the delay. I think simplifying it and just defaulting the logging to zero is a good idea. I don't have strong opinions either way. Feel free to update this PR and I'll get that merged in. Thank you.

Rennzie commented 3 years ago

No worries.

Ok cool that sounds good. Simpler is better so will update pr later today.

Rennzie commented 3 years ago

@DanielJDufour this is ready to go 🚀