GeoTIFF / georaster

Wrapper around Georeferenced Rasters like GeoTIFF and soon JPG and PNG that provides a standard interface
Apache License 2.0
87 stars 32 forks source link

Missing Tiles on COG edges where tile includes transparency #85

Open reyemtm opened 1 year ago

reyemtm commented 1 year ago

Issue Error in Leaflet using georaster-layer-for-leaflet - SOI not found.

In Node with v 2.0.7+ using geotiff directly - Cannot read properties of undefined (reading 'offset').

Use this raster as [long as it's hosted] inside georaster-layer-for-leaflet: https://tilestream-cogs.nyc3.digitaloceanspaces.com/OSU_Main_Campus_COG.tif

Expected behavior Receive an image tile - OpenLayers somehow handles these errors and is able to still return a valid tile, using geotiff version 2.0.7, but in geotiff.js in other applications such as this and in my own testing I cannot get past the errors in the getTileOrStrip code using the same version.

Desktop and Node

The issue cannot be with the geotiff library directly as OL works using the same codebase.

Leaflet

image image

OpenLayers

image
DanielJDufour commented 1 year ago

Hi, @reyemtm . Thanks for flagging this. I'll take a look.

DanielJDufour commented 1 year ago

I created a test for this file on my local repo of https://github.com/GeoTIFF/geotiff-tile and at least geotiff-tile successfully renders the tiles. I'll continue to investigate.

As background information, I'm working on getting geotiff-tile into georaster-layer-for-leaflet, so once that's done it should render accurately.

reyemtm commented 1 year ago

If you can track down the workaround for the error that would be awesome - in my use case I am using geotiff directly but noticed the errors were in this library as well. I’ll try out geotiff tile and see if that changes anything in my testing.

Thanks

On Nov 16, 2023, at 9:13 PM, Daniel J. Dufour @.***> wrote:

I created a test for this file on my local repo of https://github.com/GeoTIFF/geotiff-tile and at least geotiff-tile successfully renders the tiles. I'll continue to investigate.

As background information, I'm working on getting geotiff-tile into georaster-layer-for-leaflet, so once that's done it should render accurately.

— Reply to this email directly, view it on GitHub https://github.com/GeoTIFF/georaster/issues/85#issuecomment-1815638854, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQ2HUOTIJB5BBSL7RWBNBTYE3B5HAVCNFSM6AAAAAA7O5GAM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJVGYZTQOBVGQ. You are receiving this because you were mentioned.

reyemtm commented 1 year ago

It looks like the issue is with using -co SPARSE_OK=TRUE when creating a COG in gdal - when I set this option to FALSE I no longer get the error, at least in one test case (different file than the one above).

DanielJDufour commented 1 year ago

Wow, thanks for tracking that down! Not sure I would have figured that out :-)