Geodan / mapbox-3dtiles

3D Tiles implementation using Mapbox GL JS custom layers
BSD 3-Clause "New" or "Revised" License
297 stars 62 forks source link

External tileset broken? #41

Closed bertt closed 3 years ago

bertt commented 3 years ago

I'm using latest version of develop branch, testing external tileset.json function. I encounter the following error when using external.json (which references tileset.json):

Mapbox3DTiles.js:53981 ReferenceError: TileSet is not defined
    at ThreeDeeTile.load (Mapbox3DTiles.js:53964)
    at ThreeDeeTile.checkLoad (Mapbox3DTiles.js:54186)
    at ThreeDeeTile.checkLoad (Mapbox3DTiles.js:54192)
    at Mapbox3DTilesLayer.loadVisibleTiles (Mapbox3DTiles.js:59708)
    at Mapbox3DTiles.js:59799

Working site (references tileset.json): https://bertt.github.io/mapbox_3dtiles_samples/samples/external/index_working.html#15.62/39.160792/-75.52649/0/45

Not working site (references external.json which references tileset.json): https://bertt.github.io/mapbox_3dtiles_samples/samples/external/index_not_working.html#15.62/39.160792/-75.52649/0/45

The sample was working before upgrading to the latest commit in develop branch (old version was using mapbox-gl 1.9)

bertt commented 3 years ago

fixed in https://github.com/Geodan/mapbox-3dtiles/commit/08d886c47ee07e254e58544141aee2482cbca7af