search

Geode-solutions / OpenGeode

Open source framework for representing and manipulating geometric models
https://geode-solutions.com/opengeode
MIT License
153 stars 13 forks source link

fix(CME): add edge unique vertices #795

Closed BotellaA closed 1 year ago

BotellaA commented 1 year ago

Not sure if I prefer this or giving the version taking two unique vertices in a detail header in the namespace

Why? The model edge is defined and all component edges are found from these two unique vertices. Why not keeping them in the struct?

github-actions[bot] commented 1 year ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 14.4.8-rc.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 14.4.8 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: