Geodels / gospl

Global Scalable Paleo Landscape Evolution Model
https://gospl.readthedocs.io
GNU General Public License v3.0
62 stars 11 forks source link

JOSS review: very minor points #104

Closed cmshobe closed 3 years ago

cmshobe commented 3 years ago

This issue is part of my JOSS review: openjournals/joss-reviews#2804.

Hi @tristan-salles, congratulations on a really nice piece of software! I have used it through Docker and run the example notebooks without trouble (except for occasionally running out of memory on my machine, but that's my problem not yours).

I also find the technical guide very thorough after the changes suggested by John. I have just a couple of small reference additions to request for the paper (they may also be relevant to the technical guide). These are very minor:

I wish I had more to offer in this review, but the software is working well and the technical guide is very thorough. gospl will be a big asset to the community.

tristan-salles commented 3 years ago

Hi @cmshobe, thank you for agreeing to do the review, really appreciate it! I have made the modifications as suggested, adding the proposed references both in the technical guide and in the paper.