search

GeoffAtHome / lightwave

Reliable communication to LightwaveRF hub.
MIT License
1 stars 4 forks source link

Remove need for Proxy #9

Closed ColinRobbins closed 1 year ago

ColinRobbins commented 1 year ago

Hi Geoff,

I've made a PR to remove the need for a proxy in HA. I have the permissions I need accept the PR, and create the PyPI. Just want to check you are OK with the update before I do.

Cheers.

GeoffAtHome commented 1 year ago

Hi Colin,

Happy for you to make the change. If you want to delay, I should be able to review the change within the next 48 hours – more likely this evening.

Cheers,

Geoff

From: Colin Robbins @.> Sent: 04 January 2023 16:02 To: GeoffAtHome/lightwave @.> Cc: Subscribed @.***> Subject: [GeoffAtHome/lightwave] Remove need for Proxy (Issue #9)

Hi Geoff,

I've made a PR to remove the need for a proxy in HA. I have the permissions I need accept the PR, and create the PyPI. Just want to check you are OK with the update before I do.

Cheerrs.

— Reply to this email directly, view it on GitHub https://github.com/GeoffAtHome/lightwave/issues/9 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVW2WAE4RIIDFKPCO2754DWQWNHZANCNFSM6AAAAAATQ6PX3E . You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/ABVW2WHYV2Y7IH3NIHLZFE3WQWNHZA5CNFSM6AAAAAATQ6PX3GWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHFVDLKVI.gif Message ID: @. @.> >

ColinRobbins commented 1 year ago

A code review would be great. I’ll hold off until the weekend.

The (minimal) corresponding change for HA is in my staging area. https://github.com/ColinRobbins/Home-Assistant-Core/tree/lightwave I can’t PR that, until I’ve made this library available.

I’ve been running with it in my live systems for a week, and all seems fine.