Geolicious / qgis2leaf

A QGIS plugin to create a working leaflet based webmap from it
127 stars 30 forks source link

Idea: show attribute table #153

Open dkerkow opened 9 years ago

dkerkow commented 9 years ago

Sometimes it is good to have a data overview in a tabular structure. This could be a nice enhancement for qgis2leaf. There could be an option in the export dialogue that offers to add a switch in the resulting webmap. When activating the switch, there would open a table ( maybe a nearly fullscreen modal window over the map ) with the possibilty to sort by the different columns (asc, desc) and eventually even a filter / search box.

riccardoklinger commented 9 years ago

There is already the attribute table in the popup... one could enhance it for sure, but in my eyes it's not needed. the filter/seach on attributes would be a good idea. Does one know a minimal example using geojsons?

mtravis commented 9 years ago

This plugin will query geojson directly.

http://labs.easyblog.it/maps/leaflet-search/ On 4 Dec 2014 10:20, "Riccardo Klinger" notifications@github.com wrote:

There is already the attribute table in the popup... one could enhance it for sure, but in my eyes it's not needed. the filter/seach on attributes would be a good idea. Does one know a minimal example using geojsons?

— Reply to this email directly or view it on GitHub https://github.com/Geolicious/qgis2leaf/issues/153#issuecomment-65611626 .

riccardoklinger commented 9 years ago

so with our current setup it's not an option. see here: https://github.com/stefanocudini/leaflet-search/issues/45


Geolicious GbR Agentur für Geo-Kommunikation

Riccardo Klinger Geschäftsführer

mobil: 0176 63437298 e-mail: riccardo.klinger@geolicious.de web: www.geolicious.de

Geolicious GbR c/o Daniel Kerkow Binzstraße 48 13189 Berlin

Gesellschafter: Riccardo Klinger Daniel Kerkow Jakob Hafner

Sitz der Gesellschaft: Berlin Ust-ID: DE289107523

On Thu, Dec 4, 2014 at 11:23 AM, Matt Travis notifications@github.com wrote:

This plugin will query geojson directly.

http://labs.easyblog.it/maps/leaflet-search/ On 4 Dec 2014 10:20, "Riccardo Klinger" notifications@github.com wrote:

There is already the attribute table in the popup... one could enhance it for sure, but in my eyes it's not needed. the filter/seach on attributes would be a good idea. Does one know a minimal example using geojsons?

— Reply to this email directly or view it on GitHub < https://github.com/Geolicious/qgis2leaf/issues/153#issuecomment-65611626> .

— Reply to this email directly or view it on GitHub https://github.com/Geolicious/qgis2leaf/issues/153#issuecomment-65612036 .

dkerkow commented 9 years ago

Sure, this is not a very important feature, but I saw a request for something like this somewhere and didn't want that idea to drown in my head too quickly.

tomchadwin commented 9 years ago

The first question I ask of any feature request is: "Is this a core part of a web map, and of Leaflet". I'd argue that this is not, and that if someone wants to have such a table, they should create it themselves, and that it is not the job of the plugin to do it.

Don't get me wrong - I agree that there are many occasions when just the popups are not enough - when you need to see multiple features' data at the same time. I just don't think the plugin should be doing this.

What do others think?

tgdallas commented 9 years ago

If I want extra information I prefer to query the database directly. What kind of data can be returned from this table that are not in the database?

riccardoklinger commented 9 years ago

well, the possibility to filter on 1000 points for a special category in the webmap is quite sexy. Yet I agree somehow with @tomchadwin : qgis2leaf is a tool to export your qgis data quickly and show it. We cannot build a complete webGIS with qgis2leaf. The tool needs to stay simple....

dkerkow commented 9 years ago

Okay, I agree with you all, @tomchadwin , @riccardoklinger , @tgdallas , that this is not core functionality. Yet I've heard a reasonable user voice that asked for a tool to make available a snapshot of existing GIS data, but without the hurdle of setting up a database + management layer to give a certain non gis-affine audience the possibility to explore these datasets.

For the moment I would like to keep this issue open, and if someone comes around and implements it, we can still decide wether to make it a core feature or to put that into a leaflet plugin.

riccardoklinger commented 9 years ago

once again daniel: at the moment we are exporting the complete attribute table as part of the jsons and display it in each popup. You want to see the full attribute table, right?!

dkerkow commented 9 years ago

Right, the idea was to have widget showing the whole table at once. Like in geojson.io . But as I said, it's definitely nice to have, just wanted to leave this here.

tomchadwin commented 9 years ago

I think @dkerkow's point above is right: this should be its own Leaflet plugin (I don't think one exists). Adding a "browse layer data" button to the legend would be a great addition.

Suggest we therefore close this.

riccardoklinger commented 9 years ago

well, lets discuss this further. I think it's an interesting option to place a link in the attribution called "see data" which then leads to a simple html/csv page of the layers and their attributes. this can be just a simple "check box" in the GUI and will not be a complete messup of the core webmap?!

dkerkow commented 9 years ago

Just for reference, the user voice I cited came up on https://plus.google.com/115313929057837729405/posts/bxzWiWLoDmn

tomchadwin commented 9 years ago

Should be pretty simple to read in all the JSON from the static encoded layers. The WFS might be a little trickier, but still OK.

I'm just not sure how useful just a single link in the footer would be. Seeing the tables on a per-layer basis would be the right way to do it (and in a big pop-up, as @dkerkow suggests).

tomchadwin commented 9 years ago

I've posted an issue for Leaflet: https://github.com/Leaflet/Leaflet/issues/3078

tomchadwin commented 9 years ago

I feel ashamed:

https://github.com/Leaflet/Leaflet/issues/3078

mtravis commented 9 years ago

Requesting plugins. Whatever next ;)

If some wants to view their data then geojson.io is a could start. Might there be a way of linking to that? On 6 Dec 2014 08:07, "Tom Chadwin" notifications@github.com wrote:

I feel ashamed:

Leaflet/Leaflet#3078 https://github.com/Leaflet/Leaflet/issues/3078

— Reply to this email directly or view it on GitHub https://github.com/Geolicious/qgis2leaf/issues/153#issuecomment-65889519 .