search

Geolicious / qgis2leaf

A QGIS plugin to create a working leaflet based webmap from it
127 stars 30 forks source link

index.html broken by autolinker maybe?! #86

Closed riccardoklinger closed 10 years ago

riccardoklinger commented 10 years ago

the autohotlink breaks up the webma i think:

SyntaxError: Using //@ to indicate sourceMappingURL pragmas is deprecated. Use //# instead jquery-2.0.0.min.js:1 Error: http://code.jquery.com/jquery-2.0.0.min.js is being assigned a //# sourceMappingURL, but already has one SyntaxError: missing ) after argument list could be a problem with the length of my attribute list or my internet connection. when i creae just a small attribute list for the popup it works again...

tomchadwin commented 10 years ago

Can you consistently recreate this? I think the default behaviour of autolinker.js is to autolink Twitter hashtags/handles, so that could be the explanation. There is an option to turn the Twitter linking off. Let me find it and suggest a patch to see if that solves this.

tomchadwin commented 10 years ago

Try changing:

Autolinker.link(String(feature.properties.""" + str(field) + """)) + '"""

to:

Autolinker.link(String(feature.properties.""" + str(field) + """), {twitter: false}) + '"""

riccardoklinger commented 10 years ago

changing this as mentioned a above hasn't helped in my case. it seems that the work of Autolinker wasn't finished whenn the map was drawn. it works, when i minimize my attribute list to one attribut only. the error that will be still in the console: "SyntaxError: Using //@ to indicate sourceMappingURL pragmas is deprecated. Use //# instead jquery-2.0.0.min.js:1 Error: http://code.jquery.com/jquery-2.0.0.min.js is being assigned a //# sourceMappingURL, but already has one"

tomchadwin commented 10 years ago

OK. Can you try changing the jQuery version to >=2.1?

tomchadwin commented 10 years ago

And is there any actual problem with the output - is anything wrong, or is it just the console error? Reading around, this is a warning, not an error, and is a bug in Firefox. Apparently jQuery 2.1+ fixes it.

riccardoklinger commented 10 years ago

The Map is not visible and is not drawn with full attribute table. When limiting attributes to one or two entries it works like described In my last comment

riccardoklinger commented 10 years ago

I've now changed to 2.1.1 but maybe we should ship all necessary js libraries with the plugin... But lets move this into a new issue and close this one for the moment.