Geolykt / EnchantmentsPlus

Enchantments+, a Bukkit Custom Enchantments Plugin based on Zenchantments targetted at production grade servers
GNU General Public License v3.0
38 stars 14 forks source link

3.1.6 (user using version 1.16) Cool time error. (I can't apply it.) #106

Closed slswkrh0000 closed 2 years ago

slswkrh0000 commented 2 years ago

Hello, I am a user who used Zenchantments. As 1.16 support was not available, I transferred to a plug-in after March 2021.

I'm satisfied, but I have a question. Each magic cool time does not apply. Is it revised after version 4.0.0? Why is 1.16 recommended not to use 4.0.0?

+I'm worried if it's translated properly because it's a translator. If it is simply my problem that cool time does not apply in version 3.1.6, I would like to know the reason. If you need to update it to a higher version, please tell me how to do it. Thank you.

Geolykt commented 2 years ago

The last time cooldowns were refractored was in 3.0.0, so it could very well be that I did some messups back then. 4.+ should not be used in 1.16 because the default config files are for 1.17, so you'll get a lot of config spam at startup because blocks are not found.

slswkrh0000 commented 2 years ago

Then, is there any way to implement cool down in version 3.1.6?

Geolykt commented 2 years ago

I'll first need to see whether that is even a bug or a user error which can take quite a while because I haven't played minecraft for ages and I simply lack the motivation to even work on this plugin

Geolykt commented 2 years ago

I cannot reproduce this bug, are you sure you set it in the config file for the given world?

slswkrh0000 commented 2 years ago

I attached it below. Also, we recently updated the plug-in to 1.17 version.

world.zip ?

Geolykt commented 2 years ago

hm, would need to check whether those enchantments actually support cool-downs right now; will reopen the issue for the time being

slswkrh0000 commented 2 years ago

ok Thank you. I hope the problem will be solved soon.

eyesonme1212 commented 2 years ago

Same error as me!

Geolykt commented 2 years ago

Yeah sorry, while I know that a fix would be rather straightforward (given that the checks are simply missing hehe) I am not sure when I will find the motivation to fix it... Perhaps I'm even better off shelving the plugin as a whole

eyesonme1212 commented 2 years ago

Oh, I can't do that. Don't give up T.T It's a good plugin... There is no replacement plugin

Geolykt commented 2 years ago

Cannot reproduce. Keep in mind that for some enchantments there is no real use in having a cooldown (e.g. Jump since it is just a potion effect being applied on the player) and that the cooldown is in ms and not in ticks.