search

Geolykt / EnchantmentsPlus

Enchantments+, a Bukkit Custom Enchantments Plugin based on Zenchantments targetted at production grade servers
GNU General Public License v3.0
38 stars 14 forks source link

Fixed Tracer: Now only works more than 15 blocks away #114

Closed cpaca closed 2 years ago

cpaca commented 2 years ago

Let "dist" be the distance between the arrow and the shooter.

Previous behavior: If dist^2 > 225, NOT HOMING If dist^2 < 225, HOMING So homing arrows only work if the shooter stays within 15 blocks of the homing arrow.

New behavior: If dist^2 < 225, NOT HOMING If dist^2 > 225, HOMING So homing arrows only work if the shooter stays more than 15 blocks away from the homing arrow.

Based on the comments, this is the intended behavior. Also, you can check that it doesn't work (right now) because if you stand at point-blank range and shoot something, the arrow will immediately try to hit it.

SonicCraft commented 2 years ago

Hmm those are two very distinct behaviors, you could almost separate them into different enchantments, the new behavior being called Sharpshooter and the old behavior being called Combat Bow or something like that.

Geolykt commented 2 years ago

Thanks for the pull! I have to agree that @SonicCraft's Suggestion is good, but I'd like to stay Faithfull to the original plugin. What do the other people think about this?

Otherwise I would make this confugurable because while this is intended behaviour, this isnt the behaviour people grew to love

Geolykt commented 2 years ago

After checking git blame, the PR actually restores the original behaviour which was broken in https://github.com/Geolykt/EnchantmentsPlus/commit/9fdcbc7597361b9689166c862e609ebd0bea9d6a which was shipped in v4.0.1.

As such I will be merging this commit now without making it configurable. If anyone thinks making it configurable is beneficial or wants an enchantment with the broken behaviour, then please come forward either by creating an issue or commenting on the PR