search

Geolykt / EnchantmentsPlus

Enchantments+, a Bukkit Custom Enchantments Plugin based on Zenchantments targetted at production grade servers
GNU General Public License v3.0
38 stars 15 forks source link

Shield Durability with Ethereal #124

Open CrimsonSerpent5 opened 2 years ago

CrimsonSerpent5 commented 2 years ago

Putting Ethereal on a Shield does not make the durability go away.

Geolykt commented 2 years ago

What is your patches.yml? And does /ench list take note of your enchantment? Chances are this is working as intended

CrimsonSerpent5 commented 2 years ago

This is not working as intended and the enchantment is on all of the other items ive made and works fine other than on sheilds

On Tue, Apr 19, 2022, 1:41 PM Geolykt @.***> wrote:

What is your patches.yml? And does /ench list take note of your enchantment? Chances are this is working as intended

— Reply to this email directly, view it on GitHub https://github.com/Geolykt/EnchantmentsPlus/issues/124#issuecomment-1102917733, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASZOPHZBXKHSTWCNDURFFN3VF3V3VANCNFSM5TZRU2FA . You are receiving this because you authored the thread.Message ID: @.***>

Geolykt commented 2 years ago

Well you see by default none of the plugins enchantments can work on shields. I'd have to check whether changing that causes any issue with other enchantments though

CrimsonSerpent5 commented 2 years ago

Has this been fixed yet?

Geolykt commented 2 years ago

Everything that wasn't closed wasn't resolved yet. I am particularly slow at feature requests due to low motivation. That being said you can add shields to https://github.com/Geolykt/EnchantmentsPlus/blob/4xx/resources/magicCompat.yml#L285 and https://github.com/Geolykt/EnchantmentsPlus/blob/4xx/resources/patches.yml#L34 and it should work