Upstream-but-not-really Zenchantments (syndek/Zenchantments) has added a few changes lately. Some we might adopt, otherwise we might. This issue is mainly done to inform server owners of potential changes in the future. Furthermore discussion on this topic is highly encouraged, should one not want unwanted changes.
These are the changes that I believe to be useful if not necessary:
[ ] Add support for new food items within gluttony, such as Honey bottles (I'd probably make that configurable)
[ ] When applying gluttony, return used Itemstacks (i.e. bowls when eating stew) - dropping them on the ground if there is no space
[ ] Make Fuse arrows ignite Candles and campfires (and other blocks while we are at it - such as nether portals?)
[ ] Make Powder snow, blue ice and regular snow damage the player when using blaze's curse
[ ] Moss carpet in the list of carpets (That would be VERY fun to implement. cough).
[ ] Support AZALEA_LEAVES and FLOWERING_AZALEA_LEAVES (for transformation - lumber fortuantely supports them out of the box) - perhaps have some config option to allow cycling within a tag? Note: would need to support by name due to ordinal being dangerous to rely on in the future
[ ] Support AZALEA and FLOWERING_AZALEA as saplings (TODO: Fact check whether those are actually saplings) - this is also only of relevance for transformationand only changes the magicCompat.yml file
[ ] Register Turtle helmet as helmet (duh) within magicCompat.yml (and make sure it notices it elsewhere)
Following changes are definitely up to discussion:
Upstream removed the extraction enchantment. Makes sense since it is similar to other enchantments. How do other others see that?
FrozenStep was also removed. That may make sense but I've always found that there was a subtle difference to the vanilla enchantment. If the difference is too subtle we might want to subtly remove FrozenStep from RNG and slowly convert all FrozenStep enchantments to their vanilla equivalent
Furthermore the Gust enchantment was removed. It is beyond me why that is the case and I'd definitely avoid such a change unless there is overwhelming consensus for it (with removal I mean disabling it by default).
The fire enchantment is based on the dropped item instead of the broken block. That would have a very subtle difference but I don't think there is any merit to it.
Upstream-but-not-really Zenchantments (syndek/Zenchantments) has added a few changes lately. Some we might adopt, otherwise we might. This issue is mainly done to inform server owners of potential changes in the future. Furthermore discussion on this topic is highly encouraged, should one not want unwanted changes.
These are the changes that I believe to be useful if not necessary:
[ ] Add support for new food items within gluttony, such as Honey bottles (I'd probably make that configurable)
[ ] When applying gluttony, return used Itemstacks (i.e. bowls when eating stew) - dropping them on the ground if there is no space
[ ] Make Fuse arrows ignite Candles and campfires (and other blocks while we are at it - such as nether portals?)
[ ] Make Powder snow, blue ice and regular snow damage the player when using blaze's curse
[ ] Make Sonic shock also damage slimes and shulkers (those are not monsters for some ungodly reason). Instead of scanning for
Monsterwe could scan forEnemy(https://hub.spigotmc.org/javadocs/spigot/org/bukkit/entity/Enemy.html)[ ] Moss carpet in the list of carpets (That would be VERY fun to implement. cough).
[ ] Support AZALEA_LEAVES and FLOWERING_AZALEA_LEAVES (for transformation - lumber fortuantely supports them out of the box) - perhaps have some config option to allow cycling within a tag? Note: would need to support by name due to ordinal being dangerous to rely on in the future
[ ] Support AZALEA and FLOWERING_AZALEA as saplings (TODO: Fact check whether those are actually saplings) - this is also only of relevance for transformationand only changes the magicCompat.yml file
[ ] Register Turtle helmet as helmet (duh) within magicCompat.yml (and make sure it notices it elsewhere)
Following changes are definitely up to discussion:
Upstream removed the extraction enchantment. Makes sense since it is similar to other enchantments. How do other others see that?
FrozenStep was also removed. That may make sense but I've always found that there was a subtle difference to the vanilla enchantment. If the difference is too subtle we might want to subtly remove FrozenStep from RNG and slowly convert all FrozenStep enchantments to their vanilla equivalent
Zenchantments does some funny logic - apparently due to nonstandard bukkit implementations (see https://github.com/syndek/zenchantments/commit/7cf184aaca7ffae2cd62d37c33fcb65b17057302)
Furthermore the Gust enchantment was removed. It is beyond me why that is the case and I'd definitely avoid such a change unless there is overwhelming consensus for it (with removal I mean disabling it by default).
The fire enchantment is based on the dropped item instead of the broken block. That would have a very subtle difference but I don't think there is any merit to it.