Combine Enchanted Books to Tools in Anvil

Geolykt / EnchantmentsPlus

Enchantments+, a Bukkit Custom Enchantments Plugin based on Zenchantments targetted at production grade servers

GNU General Public License v3.0

38 stars 15 forks source link

Combine Enchanted Books to Tools in Anvil #15

Closed igummie closed 4 years ago

igummie commented 4 years ago

I'm not able to combine an enchanted book onto any of my tools or armor at an anvil

Geolykt commented 4 years ago

Thanks for the Bug report, however a bit more information is needed so it can be processed accordingly.

a) What is the current Plugin Version? b) What were the previous plugin Versions? c) What is the exact Server Version? (CB is updated multiple times a day — LATEST is a very inacurate description) d) When was the patches.yml/magicCompat.yml last reset? e) If the Plugin doesn't use default settings, which changes were made to them? f) Screenshots? (if applicable)

I highly assume that it's an User input issue, but I won't outright close the issue as of now (wouldn't be the first time that my first thoughts were wrong)

igummie commented 4 years ago

a) 2.1.4 b) first install c) paper-git-244 d) I installed the plugin yesterday e) default settings

igummie commented 4 years ago

also no worries. Probably is user error. Non of the players on my server including I could figure it out

Geolykt commented 4 years ago

It's an user error. Update to v2.1.5 and delte the magicCompat.yml (update can be found at GitHub or SpigotMC)

igummie commented 4 years ago

where is v2.1.5

Geolykt commented 4 years ago

Oh oof, mistook v2.1.4 as v2.1.3 (where the exact issue persisted) because I forgot that v2.1.5 is still indev. Either way, I'll attempt to reproduce it. It's likely a duplicate of another issue which has been already fixed. Try damaging the source item first.

igummie commented 4 years ago

no dice. however i just found another bug trying to put it on a damged pic with enchants already on it however it doesn't actually add bind to the picaxe but addes some blank null value I assume

Geolykt commented 4 years ago

Did some tests and I was able to reproduce it. As the class that was in charge of the merging is hardly maintainable I decided to rewrite it. However I came to the same issue, but I now know where the issue is and how it can be fixed.

The exact issue lies in that the default Enchantment getter automatically returns an empty list for enchanted books as it's not in the allowlist, to fix the issue following things can be performed:

Use a primitive getter such as PR47-lore or lwNBT (can be set within the patches.yml)
Add the book entry under getterAllow within the patches.yml

The issue will be resolved under v2.1.5, but in the meantime it can be fixed via the actions above.