search

Geolykt / EnchantmentsPlus

Enchantments+, a Bukkit Custom Enchantments Plugin based on Zenchantments targetted at production grade servers
GNU General Public License v3.0
38 stars 15 forks source link

Luck of the sea does not work (1.16.3, running in Paper of that version) #25

Closed Smash-Nerd closed 3 years ago

Smash-Nerd commented 3 years ago

I certainly get more junk, but Luck of the Sea itself does not pull any enchanted books anymore.

Geolykt commented 3 years ago

Pretty much impossible

Smash-Nerd commented 3 years ago

I have no idea how that helps me in my current situation. i'll try reinstalling the plugin.

Geolykt commented 3 years ago

The plugin does not alter fishing drops at all, I could investigate the issue further, but it's very unlikely that that is the case. Are any enchantments on the rod? If no, then the issue is not worthy of being reopened without further proof, else, well then there is a chance that the plugin is actually at fault here

Smash-Nerd commented 3 years ago

I'm doing a pretty big fishing session right now and comparing my loot with the actual statistics found here https://minecraft.gamepedia.com/Fishing#Junk_and_treasure I'll respond to this comment with my findings, but so far, no books, tools, or anything. I've gotten more junk that tools, and Junk is FAR less likely to get than said tools.

EDIT: If it helps, the rod I'm using is running Luck of the Sea 2, Lure 2, Unbreaking 3, and Bind. However, the rod was created back when we were still running Zenchantments via Bukkits Upwards compatibility, if that would mess with the items at all.

Geolykt commented 3 years ago

It wouldn't (or at least) shouldn't mess with it at all if you were using Zenchantments with 1.15.2 or NMS-less Zenchantments with 1.16.1/1.16.2. I'll look into it, although I have no idea on what could be the cause there, so I cannot guarantee that it will be fixed anytime soon. Does /ench info on the tool output what is expected?

Smash-Nerd commented 3 years ago

Yeah it pops out with what it should. " Enchantment Info: Bind: Keeps items with this enchantment in your inventory after death "

Interesting. I'll keep fishing.

Smash-Nerd commented 3 years ago

Alright, these were the drops I got. When comparing them to the LotS2 section of the Fishing table at the link I previously provided, you'll see that the chances are totally out of wack. However what I did find interesting was I got a single, untenchanted fishing rod. Another interesting thing to note is from the wiki page from this link https://minecraft.gamepedia.com/Fishing#cite_note-Treasure-2 "(...) Enchantment probabilities are the same as a level-30 enchantment on an enchanting table. These can also include treasure enchantments that are unavailable via an enchanting table." It may have something to do with that, but IDK.

2020-12-17_15 38 03

EDIT: the image didn't attach. Fixed that

Geolykt commented 3 years ago

I'll look into it, thanks. however the fishing rod isn't anything interesting on it's own due to it being most likely a junk fish.

Do you have anything else that could modify the fishing loot table?

Smash-Nerd commented 3 years ago

I'm not really a programmer so no. I guess I could try an unenchanted rod and see where that gets me. The wiki says its a 5% chance for a loot pull without LOTS. I'll see if that stacks up to what we've been seeing so far.

Smash-Nerd commented 3 years ago

I've just recalled something

When we were running Upwards compatible zenchantments, my first pull was an Enchanted book. And something I've just noticed is I have not pulled a single item from the Treasure table. The fishing rod is also in the junk table, so the Treasure table is totally untouched.

Also i've gone through half this unenchanted rod and still no sign of any treasure.

Smash-Nerd commented 3 years ago

Wait it fixed itself. IDK how tho.

Geolykt commented 3 years ago

Then I'll close the issue, but it was one strange one

Smash-Nerd commented 3 years ago

Extremely. Maybe fishing works differently from when it did in 1.14?