Geolykt / EnchantmentsPlus

Enchantments+, a Bukkit Custom Enchantments Plugin based on Zenchantments targetted at production grade servers
GNU General Public License v3.0
38 stars 14 forks source link

Allow for Villager and Enchanted Book Support #51

Open MysteryTimeTrav opened 3 years ago

MysteryTimeTrav commented 3 years ago

Hi, this is an enhancement request.

Is it possible to allow for these enchantments to be obtained via an enchanted books and by extension have them be sold by villagers?

Geolykt commented 3 years ago

The enchantments are already obtainable via enchanted books, however villager selling them has not yet been implemented. I might add that one day, but given that I have never poked a villager trades, this may as well never happen (just like Trident support [though for it I'm waiting on feedback from a fork]).

jaspqrr commented 2 years ago

did you ever add this? and if not how do you obtain enchantments in survival and are the enchantments usable on players?

Geolykt commented 2 years ago

Enchantments are available through the enchantment table. However villagers still do not sell these enchantments

jaspqrr commented 2 years ago

oh okay thank you and are you still considering to add it through villagers?

Geolykt commented 2 years ago

It is planned to do it eventually, but no efforts are underway as of now. That is if someone makes a PR it is likely to get accepted - if noone does it it might take an unknown amount of time until that gets implemented. I myself as a player don't really find it annoying that villagers don't sell the books so therefore I don't really have a motivation to add it and always delay it to "later"

jaspqrr commented 2 years ago

Okay thanks!