Spectral can crash the server

[Geolykt]

Affected enchantment(s):

• Spectral

  Steps to reproduce:

  • Get a shovel with the spectral enchantment
  • Shift and hold right click

Main symptom(s):

• Lag, Crash

Secondary symptom(s):

• Increased Memory usage (GC is however running well)

Possible resolution(s):

• Fixing/Nerfing Spectral range (something is wrong with the Spectral range calculation either way)
• Increase Spectral cooldown
• Reduce permission querying

Additional notes:

Due to the high and rapid spike of Memory usage, it is likely that we are dealing with the fact that the plugin cannot handle massive amounts of data quickly and that a very high amount of objects are created, fixing it might be performed by recycleing objects, more specificially the permission query object.

[Geolykt]

It should be mitigated, however I must stress that this is mitigated, so not much performance improvements. I'd likely conduct polls on how the enchantment is used to be able to optimise it further, but from what I see I can only optimise it by rearraging the if-else blocks to prioritize the most likely senario