Geolykt / EnchantmentsPlus

Enchantments+, a Bukkit Custom Enchantments Plugin based on Zenchantments targetted at production grade servers
GNU General Public License v3.0
38 stars 14 forks source link

Fire Enchant and Fortune Enchantment dropping excessive amounts of ingots from ores. #96

Closed GentlemanCheesy closed 2 years ago

GentlemanCheesy commented 2 years ago

Currently using the newest version of the plugin which I believe is 4.0.1 and came across the following issue. No errors were popping up in console either. Feel free to ask for a list of plugins I'm using! Thank you for any responses in advance!

I'm not sure why but when I mine with a pickaxe that has both fortune and fire, ores (Iron, Copper, Gold) drop too many extra ingots. I have found that with fortune 2 a single ore can drop sometimes up to 12 ingots. With fortune 3 being even worse. My suggestion would be to set it so that it works the same as fortune on diamond ore would.

Example of a pickaxe I used when testing this bug image

Total of 6 broken iron ore dropped on the ground. image

Geolykt commented 2 years ago

Yeah, this is heavily broken. Will look into it, it is likely that spigot changed the fortune code around so we don't need to account for fortune ourselves

GentlemanCheesy commented 2 years ago

Any update on what is causing this? I saw you recently pushed an update, and just wanted to know if this bug was still in the process of being fixed since it still occurs in the latest version!

Thanks in advance!

Geolykt commented 2 years ago

Fixed. Apparently this bug has been there since day 1 of this project (not present in upstream zenchantments though), so I'm surprised that this was the only issue that was opened regarding this bug. I don't want to know how much more of these bugs are lingering around