search

GeomScale / dingo

A python library for metabolic networks sampling and analysis
GNU Lesser General Public License v3.0
44 stars 28 forks source link

rounding.py is excluded from github actions #72

Open TolisChal opened 1 year ago

TolisChal commented 1 year ago

The test file sampling.py is not included in the github actions. However, when I added it fails.

vfisikop commented 6 months ago

sampling.py is included in github actions and runs correctly but rounding.py is not included and it fails if added.

vfisikop commented 6 months ago

I reopen it since we have to find a way to run gurobi based tests on CI.

hariszaf commented 6 months ago

This is possible but we will have to update or extend the license from time to time. What we need is a Web License Service

vissarion commented 6 months ago

Also there is non gurobi rounding version. And this exposes a deeper issue: the slow* and fast* function design where there is a lot of duplicate code and they are difficult to maintain or extend. This could be (partially) fixed by designing a more generic interface to lp solvers (see https://github.com/GeomScale/dingo/issues/84).

hariszaf commented 6 months ago

Then it's maybe better instead of going through the WLS task, to work on the #84 so we move to optlang

"Optlang provides a common interface to a series of optimization tools, so different solver backends can be changed in a transparent way."

so we do not care of maintaining more than one implementations for the same task