search

GeomScale / dingo

A python library for metabolic networks sampling and analysis
GNU Lesser General Public License v3.0
42 stars 27 forks source link

Dockerfile is added to the codebase #79

Open ai-naymul opened 10 months ago

ai-naymul commented 10 months ago

The dockerfile is added which use the Gurobi docker image

Fixes #78

vissarion commented 10 months ago

@ai-naymul thanks for this PR.

I think it is better if we add that file inside doc maybe in a directory called docker or something that will contain that file and a README with instructions on how to use it. As for example, https://volesti.readthedocs.io/en/latest/getting_started/install.html#development-environment-from-docker-container

@hariszaf what do you think?

@ai-naymul ideally a github action could be added to test that the dockerfile works as expected.

ai-naymul commented 10 months ago

@ai-naymul thanks for this PR.

I think it is better if we add that file inside doc maybe in a directory called docker or something that will contain that file and a README with instructions on how to use it. As for example, https://volesti.readthedocs.io/en/latest/getting_started/install.html#development-environment-from-docker-container

@hariszaf what do you think?

@ai-naymul ideally a github action could be added to test that the dockerfile works as expected.

Yeah we should add that instructions stuff after the installation section in the README file...

ai-naymul commented 10 months ago

@vissarion should I work on the readme file instruction part of these PR right now and make a commit in the same pr or make another PR regarding that?

vissarion commented 10 months ago

I think it is better to do it in this PR. Do you confirm that the docker file you wrote works? What are the commands such that we can reproduce that? Are you able to build dingo in that container and run the tests?

hariszaf commented 10 months ago

Hi @vissarion and @ai-naymul

here you may find a working Dockerfile.

as I do not know if that's in a best-practices way, please have a look and share thoughts. :taco:

ai-naymul commented 10 months ago

I think it is better to do it in this PR. Do you confirm that the docker file you wrote works? What are the commands such that we can reproduce that? Are you able to build dingo in that container and run the tests?

Okay I will make the changes

ai-naymul commented 10 months ago

I tried this Dockerfile and its current version fails. Maybe if you follow the steps described inline, it might work.

Oh..I didn't notice that the gurobi is not in pypi library , I am sorry I will fix this asap

ai-naymul commented 10 months ago

@hariszaf @vissarion could you please check the recent commit...!!