GeomScale / dingo

A python library for metabolic networks sampling and analysis
GNU Lesser General Public License v3.0
44 stars 28 forks source link

solve issue #83: generate_steady_states fails when you edit a model's optimal percentage twice #83 #90

Closed rkstu closed 4 months ago

rkstu commented 7 months ago

Apologies for any confusion—I just realized that I unintentionally deleted the repository (when I was creating a new fork for #89 ) from which I created the initial pull request, resulting in its closure. I've submitted a new pull request to address the same issue(https://github.com/GeomScale/dingo/pull/85). I appreciate your understanding and apologize for any inconvenience caused. I am still working on this

vfisikop commented 6 months ago

Is this PR still active?

rkstu commented 6 months ago

Thanks for checking in! This PR is still active and I'm currently investigating a potential issue with the fast_mmcs function in volestipy.pyx

rkstu commented 5 months ago

I've tried a bunch of different things, I haven't been able to completely fix it yet. The program output keeps acting weird - sometimes executing entirely as expected, but at other times terminating prematurely. This makes me think it might be due to fast_mmcs function in volestipy.pyx. I'm pretty sure that's where the problem is coming from, but deeper understanding of the project is needed to be sure and actually solve it.