search

GeomScale / volesti

Practical volume computation and sampling in high dimensions
GNU Lesser General Public License v3.0
142 stars 114 forks source link

Fix ambiguous call to fix function #263

Closed vissarion closed 1 year ago

vissarion commented 1 year ago

This fixes a compile issue with ambiguous call to fix function defined in both diagnostics/raftery_subroutines/empquant.hpp and Eigen/src/Core/util/IntegralConstant.h. The PR renames the function to round_to_zero() which is conceptually closer to what that function does.

NOTE: I think that function should return an int but this can be fixed in the future since it involves changes other parts of the library.

TolisChal commented 1 year ago

Thanks @vissarion! Looks good to me.