GeomScale / volesti

Practical volume computation and sampling in high dimensions
GNU Lesser General Public License v3.0
142 stars 114 forks source link

ZPolytopes Volume #268

Closed bsarthak16 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #268 (9f7d339) into develop (6b359f4) will increase coverage by 0.12%. The diff coverage is 57.14%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/GeomScale/volesti/pull/268/graphs/tree.svg?width=650&height=150&src=pr&token=FW5NNA6B18&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GeomScale)](https://codecov.io/gh/GeomScale/volesti/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GeomScale) ```diff @@ Coverage Diff @@ ## develop #268 +/- ## =========================================== + Coverage 53.85% 53.97% +0.12% =========================================== Files 105 105 Lines 6167 6166 -1 Branches 2874 2874 =========================================== + Hits 3321 3328 +7 + Misses 972 964 -8 Partials 1874 1874 ``` | [Impacted Files](https://codecov.io/gh/GeomScale/volesti/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GeomScale) | Coverage Δ | | |---|---|---| | [...clude/diagnostics/raftery\_subroutines/empquant.hpp](https://codecov.io/gh/GeomScale/volesti/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GeomScale#diff-aW5jbHVkZS9kaWFnbm9zdGljcy9yYWZ0ZXJ5X3N1YnJvdXRpbmVzL2VtcHF1YW50LmhwcA==) | `62.50% <0.00%> (ø)` | | | [include/diagnostics/raftery.hpp](https://codecov.io/gh/GeomScale/volesti/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GeomScale#diff-aW5jbHVkZS9kaWFnbm9zdGljcy9yYWZ0ZXJ5LmhwcA==) | `53.84% <66.66%> (+0.81%)` | :arrow_up: | | [...walks/crhmc/additional\_units/dynamic\_step\_size.hpp](https://codecov.io/gh/GeomScale/volesti/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GeomScale#diff-aW5jbHVkZS9yYW5kb21fd2Fsa3MvY3JobWMvYWRkaXRpb25hbF91bml0cy9keW5hbWljX3N0ZXBfc2l6ZS5ocHA=) | `88.37% <0.00%> (+16.27%)` | :arrow_up: |
bsarthak16 commented 1 year ago

I have improved the PR please have a look on it and for more detailed information about z-polytopes and the changes i have done please check https://docs.google.com/document/d/1c6JdsPId9ujUYgDOyMPkGfhd-8KQhV5ybcKv-Txrxrg/edit?usp=sharing

vissarion commented 1 year ago

There is a confusion between Zpolytopes and Vpolytopes. Your example is a copy from https://github.com/GeomScale/volesti/blob/develop/examples/vpolytope-volume/vpolytopevolume.cpp

bsarthak16 commented 1 year ago

Hi I am very sorry for what i did i used the v polytope code for help to make a program for z polytope but i accidently pasted the v-polytope code there i am again very sorry for that and i have this time made the write changes and sorry for wasting your time