search

GeomScale / volesti

Practical volume computation and sampling in high dimensions
GNU Lesser General Public License v3.0
142 stars 114 forks source link

Efficient burn in for sampling #298

Closed vgnecula closed 2 weeks ago

vgnecula commented 3 months ago

Modified the sampling.hpp to solve: Inefficient handling of burn in phase in sampling functions #180.

Handling burn in phase without storing the points required for this phase, for each of the sampling methods presented.

Cleared my branch non-related developments in order to emphasize just the sampling.hpp code.

TolisChal commented 3 months ago

@vgnecula thanks for this PR!

A general comment is, when you want to change a particular part of the code, just change this one without affecting anything else. Then, it's easier to review the code and be sure about the changes.

vfisikop commented 3 months ago

Also it seems that you are deleting (by mistake) some crucial parts of the code in sampling.hpp.

vfisikop commented 3 months ago

Side comment: there is no need to open a new PR every time you want to change something in your branch, just update your branch!

vgnecula commented 3 months ago

@TolisChal @vfisikop just commited a new version, which adresses all your comments (find it as - minor probem with CRHMC solved - the last version of my new modifications). On my end it passes all tests. However, it takes way too much time to process crhmc_test_polytope_sampling. Besides, as you will probably see, I modified some functions, as I did not like some details that I implemented before.