Geometrically / Gravestones

A gravestones mod for FabricMC!
Creative Commons Zero v1.0 Universal
9 stars 15 forks source link

Incompatability with Backslots #19

Open Alpha-Flyte opened 3 years ago

Alpha-Flyte commented 3 years ago

When dying and picking up your grave, items stored in Backslots' slots are deleted. This is quite annoying, especially since the slots are for tools. Wouldn't want to lose your netherite pick when you crash into a wall while flying, now would you?

MC Ver.: Fabric 1.16.3

Crashlog: None, doesn't crash the game, just deletes items

JuergenSchT commented 3 years ago

The latest version of BackSlot fixed the wiping of the items in that mod's slots, and now they are dropped on the ground (like any mod slot from Curios API). I assume that for full compatibility with BackSlot, its author would have to create an API that would be used for compatibility on Gravestones (as is the case for Trinkets).

evstarMC commented 3 years ago

A related incompatibility: breaking the gravestone with items in the backslots causes those items to be deleted.

JuergenSchT commented 3 years ago

A related incompatibility: breaking the gravestone with items in the backslots causes those items to be deleted.

That's part of a general issue with Gravestones and the "place grave items on the inventory" feature: The more full the inventory was, the chance of items changing slots or disappearing increases. It happened with both vanilla inventory slots and modded slots [greacer chance with the latter]. It was noted multiple times for players in my server. The current solutions are to either completely clear one's inventory before breaking the grave, or to change Gravestone Drop Type to DROP_ITEMS.